Although there are several implementations of binary search tree, I have made my own implementation for practice. The following code does the followoing operation - Create a binary tree - search through a binary tree - inorder traversal - preorder traversal - breadth first traversal - depth first traversal post order. Thanks david-harkness for pointing out the extra shortcut!

Also, this initialization is pointless, as you overwrite the value of runner immediately in the loop:. And, the cast is also pointless, because the Queue is correctly declared with TreeNode type.

The depthFirstSearch method will set all node.

Actually it's really bad to have side effects like this. It would be better if TreeNode didn't have the visited field at all. It's polluting the class with data only used by one specific purpose, the depth-first search.

It doesn't belong there. You could track what was visited using a Setused only in depthFirstSearch. I would rename leftNode to left and rightNode to right. It's simpler and everybody understands what they are. The current implementation is limited to int values. It would be better if the BST could store anything comparable. Replace all comparison operations like x.

Your basic test could easily become more useful and less basic if you do a get not only for one random element, but for all elements you inserted, since you have the array of values ready anyway:. A single test case named basicTest is not going to make this class "properly tested".

At the very least you could add a few more test cases that are obviously necessary when talking about a binary search tree. Of course this requires a. Basically, use your IDE to format code correctly. It also makes it easier to review. I try not to cover ground already touched upon by janos's great answer except to emphasize formatting. You mostly do a good job with the indentation which is clearly the most important factor, but breadthFirstSearch has a while loop whose body isn't indented. Consistent spaces around operators looks like you dostructural parentheses ifwhileetcand braces is important, too.

Naming two traversal methods Search is misleading. You aren't searching for a specific value. Use traverse or visit instead. Tree traversal cries out for recursion! So many of your methods would be simpler using recursion instead of loops, stacks, queues, and visited flags is that flag even necessary with the looping algorithm? Ah, reading further I see you tmb forex in india this for preOrderTraversal and inOrderTraversal.

Why the difference for post-order? You can also employ recursion in the other methods such as get and insert. You'll need a helper method to start the recursion, and you can move the recursive methods to Binary search tree traversal java code if you like.

java - Binary search tree with tree traversal - Code Review Stack Exchange

I agree with the reviews by David Making money with microsoft excel and janos. I wanted to add a minor point: You can then implement a Consumer that just prints out values, but your code could also be used for other things.

By posting your answer, you agree to the privacy policy and terms of service. Sign up or log in to customize your list. Stack Equity trading systems wiki Inbox Reputation and Badges.

Questions Tags Users Badges Unanswered. Code Review Stack Exchange is a question and answer site for how to use fibonacci spiral trading programmer code reviews.

Join them; it only takes a minute: Here's how it works: Anybody can ask a question Anybody can answer The best answers are voted up and rise to the top. Binary search tree with tree traversal.

Inorder TraversalInorder Traversal - Programmer and Software Interview Questions and Answers

The following code does the followoing operation - Create a binary tree - search through a binary tree - inorder traversal - preorder traversal - breadth first traversal - depth first traversal post order Please suggest improvements or possible short comming in the code import static org. Simplify get You can simplify the get method like this: Breadth-first search It's called breadth-first, not "breath-first".

Also, this initialization is pointless, as you overwrite the value of runner immediately in the loop: Depth-first search The depthFirstSearch method will set all node. TreeNode I would rename leftNode to left and rightNode to right.

Since you never need to change datait can be final. Change the class declaration to this: For example, what happens if you try to get non-existent elements?

java - BinarySearch Tree implementation & traversals - Code Review Stack Exchange

You could simplify get even further with while runner! Maybe not simpler per se, but more what I'm used to seeing. Great idea, thanks for that!

Why are the traversal methods static? David Harkness 8, 1 18 I have implemented some methods using iteration while other using recursion for practicing both approaches. Thanks for the review.

Sign up or log in StackExchange. Sign up using Facebook. Sign up using Email and Password. Post as a guest Name. Code Review Stack Exchange works best with JavaScript enabled. Another option is to implement each traversal method as an iterator. MathOverflow Mathematics Cross Validated stats Theoretical Computer Science Physics Chemistry Biology Computer Science Philosophy more 3.

Meta Stack Exchange Stack Apps Area 51 Stack Overflow Talent.